Code

Mesh3d cell data checks#3369

Code

Merged

archmoj merged 16 commits intomasterplotly/plotly.js:masterfrom

2630-mesh3d-dont-modify-messy-dataplotly/plotly.js:2630-mesh3d-dont-modify-messy-dataCopy head branch name to clipboard

Jan 7, 2019

Commits

Commits on Dec 21, 2018

• removed indices convert

  archmoj

  committed
  12f3e1f

  Copy full SHA for 12f3e1f

• if no indices then trace visible to false

  archmoj

  committed
  33e2b9a

  Copy full SHA for 33e2b9a

• check for vertex data only

  archmoj

  committed
  f1772a2

  Copy full SHA for f1772a2

Commits on Jan 3, 2019

• Merge remote-tracking branch 'origin/master' into 2630-mesh3d-dont-modify-messy-data

  archmoj

  committed
  e531e4e

  Copy full SHA for e531e4e

• revised code after 1st review 3369

  archmoj

  committed
  65a5806

  Copy full SHA for 65a5806

• improved condition checks and added jasmine tests for mesh3d

  archmoj

  committed
  e97f5ed

  Copy full SHA for e97f5ed

• added more logic

  archmoj

  committed
  55e5e12

  Copy full SHA for 55e5e12

• revert optional deps

  archmoj

  committed
  79deeae

  Copy full SHA for 79deeae

• fixed syntax

  archmoj

  committed
  bf51940

  Copy full SHA for bf51940

Commits on Jan 4, 2019

• using loops instead of map in mesh3d convert

  archmoj

  committed
  83060bc

  Copy full SHA for 83060bc

• moved certain condition checks to convert step

  archmoj

  committed
  a041e51

  Copy full SHA for a041e51

• pass 2 removed some extra checks

  archmoj

  committed
  2b54f14

  Copy full SHA for 2b54f14

• fixed jasmine tests to also check for position and cell data

  archmoj

  committed
  a9ab05f

  Copy full SHA for a9ab05f

• improved jasmine tests and -0.49 > 0 round edge case

  archmoj

  committed
  ec502ee

  Copy full SHA for ec502ee

Commits on Jan 7, 2019

• traceIn > traceOut and more jasmine tests

  archmoj

  committed
  fadce01

  Copy full SHA for fadce01

• must have tested traceOut after coerce fix

  archmoj

  committed
  29f5a06

  Copy full SHA for 29f5a06