Skip to content

Bug fix - adjust tick distances in perspective views #3308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 6, 2018
Merged

Bug fix - adjust tick distances in perspective views #3308

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
28071db
apply changes in gl-axes3d
archmoj Dec 5, 2018
2eeda5a
changed test after near clip applied in gl-axes3d
archmoj Dec 5, 2018
4f9f839
added new mock and baseline for previous state
archmoj Dec 6, 2018
944325a
correct baseline using branch
archmoj Dec 6, 2018
fa7f028
using gl-plot3d 1.6.1
archmoj Dec 6, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 8 additions & 10 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@
"gl-mat4": "^1.2.0",
"gl-mesh3d": "^2.0.2",
"gl-plot2d": "^1.4.0",
"gl-plot3d": "^1.6.0",
"gl-plot3d": "git://github.com/gl-vis/gl-plot3d.git#417c23ae4e17476114ed02cdca3e8ddd0b417d1d",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gl-vis/gl-plot3d#17

"gl-pointcloud2d": "^1.0.1",
"gl-scatter3d": "^1.1.0",
"gl-select-box": "^1.0.2",
Expand Down
8 changes: 4 additions & 4 deletions test/jasmine/tests/gl3d_plot_interact_test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -714,15 +714,15 @@ describe('Test gl3d plots', function() {
.then(done);
});

it('@gl axis ticks should not be set when axis _length is NaN', function(done) {
it('@gl should not set _length to NaN and dtick should be defined.', function(done) {
Plotly.plot(gd,
{
data: [{
type: 'scatter3d',
mode: 'markers',
x: [1, 2],
y: [3, 4],
z: [5, 6]
z: [0.000000005, 0.000000006]
}],
layout: {
scene: {
Expand All @@ -737,8 +737,8 @@ describe('Test gl3d plots', function() {
)
.then(function() {
var zaxis = gd._fullLayout.scene.zaxis;
expect(isNaN(zaxis._length)).toBe(true);
expect(zaxis.dtick === undefined).toBe(true);
expect(isNaN(zaxis._length)).toBe(false);
expect(zaxis.dtick === undefined).toBe(false);
})
.catch(failTest)
.then(done);
Expand Down