Skip to content

regl-scatter2d bug fix - to keep trace colors #3242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

regl-scatter2d bug fix - to keep trace colors #3242

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
bfe70a8
correct size check in module
archmoj Nov 13, 2018
614c6a8
revised regl-scatter2d module for 256 color palette
archmoj Nov 14, 2018
f592232
using palette with 256x256 colors
archmoj Nov 14, 2018
bcbe705
more fixes in the module
archmoj Nov 14, 2018
fda744d
test markers
archmoj Nov 14, 2018
71b528e
test new module would display sdf markers in yellow
archmoj Nov 25, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@
"regl": "^1.3.7",
"regl-error2d": "^2.0.5",
"regl-line2d": "^3.0.12",
"regl-scatter2d": "^3.0.6",
"regl-scatter2d": "git://github.com/a-vis/regl-scatter2d.git#0515a47c5468363d19654fcb9383d7135c93c8ad",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/gl-vis/regl-scatter2d/compare/plotly-issue-3232

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this brings the max number of colors in a WebGL texture to 256x256=65536, and falls back to plain buffer beyond that? That's amazing! I gotta be honest, I don't fully understand your split8Uint dance, maybe you could explain it to me in person before or after the meeting tomorrow?

Now, looks like your latest commit made several image test cases fail, do you know why that is?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I would fix this today. Don't worry about the failed image test for the moment. There are a bunch of commits which are not yet pushed to gl-vis.

"regl-splom": "^1.0.4",
"right-now": "^1.0.0",
"robust-orientation": "^1.1.3",
Expand Down