Skip to content

circleci update plot-schema.json during publish job #3160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 25, 2018

Conversation

antoinerg
Copy link
Contributor

Fixes #3159

@antoinerg antoinerg added bug something broken type: maintenance labels Oct 25, 2018
@antoinerg antoinerg closed this Oct 25, 2018
@antoinerg antoinerg deleted the 3159-ci-plot-schema branch October 25, 2018 18:40
@antoinerg antoinerg restored the 3159-ci-plot-schema branch October 25, 2018 18:48
@antoinerg antoinerg reopened this Oct 25, 2018
@antoinerg
Copy link
Contributor Author

antoinerg commented Oct 25, 2018

Actually, is the current PR OK?

The other alternative is to run npm run build during the publish job and not have code duplication. This would come at the expense of building everything which takes 2-3 minutes. Since it runs in parallel and it's faster than test-(image|jasmine), it wouldn't slow down the whole suite.

@etpinard
Copy link
Contributor

I like this solution using ./util/browserify_wrapper is DRY enough

Thanks! 💃

@antoinerg antoinerg merged commit 0a310c9 into master Oct 25, 2018
@antoinerg antoinerg deleted the 3159-ci-plot-schema branch October 25, 2018 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants