sankey - fix issue with large padding #3143
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antoinerg
added
bug
antoinerg
changed the title
antoinerg
commented
Oct 23, 2018
package.json
Outdated
| @@ -57,7 +57,7 @@ | |||
| }, | |||
| "dependencies": { | |||
| "3d-view": "^2.0.0", | |||
| "@plotly/d3-sankey": "^0.5.0", | |||
| "@plotly/d3-sankey": "git://github.com/plotly/d3-sankey.git#6f19390be0da4a81abf6f7f6cfdf5fc8dc73e583", | |||
There was a problem hiding this comment.
See the PR associated with the changes: plotly/d3-sankey#3
|
Original codepen in issue: https://codepen.io/rbakker/pen/gBjXde |
|
@alexcjohnson What are the next steps I should do before merging this PR? Should I publish |
yep 🚀 and then update the package.json and package-lock.json in this PR. |
|
💃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3140 !
If
node.padis too large and overridden during the rendering step, aLib.warncall is made to let the user know.