-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Fix to remove webgl warnings resulted from blank texts in scatter3d #3133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Changes from 2 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
f7ba9be
fix for blank text in webgl for scatter3d
archmoj 4635012
update package lock - fix for issue 704
archmoj 9a93d02
added a jasmine test
archmoj 0e59ff2
corrected the syntax
archmoj 3822993
prototype for test
archmoj d3a2b5d
using new module is-string-blank and more fixes in gl-scatter3d
archmoj 263c80c
keep bounds cals as before
archmoj 8c10f4e
testing with fast-isnumeric branch that uses is-string-blank module
archmoj f180f4c
added mock and revised gl-scatter3d
archmoj 5737d0a
edited mock and replaced undefined cases with null for JSON
archmoj b6195fe
correct baseline - now ready for review
archmoj File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gl-vis/gl-scatter3d@master...issue-704
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTW now that you have PRs in these other repos, even better than the branch link would be to link to that PR directly
gl-vis/gl-scatter3d#9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the note. But the other PR on the gl-scatter3d repo is not opened by me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My apologies @alexcjohnson,
Here is the link to the open PR:
gl-vis/gl-scatter3d#9