Parcoords issues with extra update call #3112
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This doesn't seem to me to be removing an update, so much as converting an update into a new object creation call. Which does seem to fix the issue, but also slows down updates a good deal (and might lead to a memory leak? That I'm not sure about, depends on what's contained in the Anyway, I think we had better look a little deeper and see what it would take to fix |
|
Yes I totally agree with you that this requires more tests. |
|
We could close this PR now that the issues are addressed in these two different PRs: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regarding issues #3099 and #3101 this patch removed an extra update call which may be the source of this problem. Please notice that lineLayerMaker itself also calls the update method to redraw.
@alexcjohnson