Skip to content

Make polar be more graceful on non sense inputs #3021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Sep 18, 2018
Merged

Make polar be more graceful on non sense inputs #3021

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
7f0fc26
don't attempt to draw radial axis when *polar.hole* is set to 1
etpinard Sep 14, 2018
8589d99
no need to draw inner sector when range[0] is clamped to origin
etpinard Sep 17, 2018
a8838da
draw sectors that span more than 2pi as 'full' circle
etpinard Sep 17, 2018
35d1351
id should be a string not a length-1 array
etpinard Sep 17, 2018
b3fc904
try adding @noCI to plotly_webglcontextlost test
etpinard Sep 17, 2018
d9d626a
tag new select test as @flaky
etpinard Sep 17, 2018
cb5b336
add hole=1 subplot to polar_blank mock
etpinard Sep 17, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/jasmine/tests/gl2d_plot_interact_test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,7 +215,7 @@ describe('Test gl plot side effects', function() {
.then(done);
});

it('@gl should fire *plotly_webglcontextlost* when on webgl context lost', function(done) {
it('@noCI @gl should fire *plotly_webglcontextlost* when on webgl context lost', function(done) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

4 successes in 4 test-jasmine2 runs with this @noCI

var _mock = Lib.extendDeep({}, require('@mocks/gl2d_12.json'));

function _trigger(name) {
Expand Down