Expose Plotly.purge method #300
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- built on top of Plots.purge. - In addition, clears <div class="plot-container"> - In addition, clears gl contexts using Plots.cleanPlot
| var myImage = new Image(); | ||
| myImage.src = figDir + plotname + '.png'; | ||
|
|
||
| image.innerHTML = ''; | ||
| image.appendChild(myImage); | ||
|
|
||
| gd = document.createElement('div'); | ||
| gd.id = 'graph'; |
There was a problem hiding this comment.
@mdtusz not sure why I didn't do this before, now you can use Plotly.plot('graph', [], {}) in the test-dashboard.
|
💃 |
- which all event method from the plot object
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #126
@mdtusz @mikolalysenko @alexcjohnson @emackey
supplementary background info in #117 and #132
In brief, this PR adds a
purgemethod to the our official API on thePlotlyobject.Whereas, the internal
Plotly.Plots.purgeis meant to prepare the state for subsequentPlotly.plotcalls (e.g whatPlotly.newPlotdoes essentially), the proposedPlotly.purgeclear the state -- including the gl contexts -- and the graph div instead without the documented all hell braking loose.