Shard gl jasmine tests #2933
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,112 @@ | ||
| var fs = require('fs'); | ||
| var path = require('path'); | ||
|
|
||
| var falafel = require('falafel'); | ||
| var glob = require('glob'); | ||
| var minimist = require('minimist'); | ||
|
|
||
| var constants = require('./util/constants'); | ||
| var pathToJasmineTests = constants.pathToJasmineTests; | ||
|
|
||
| var argv = minimist(process.argv.slice(2), { | ||
| string: ['tag', 'limit'], | ||
| alias: { | ||
| tag: ['t'], | ||
| limit: ['l'], | ||
| }, | ||
| default: { | ||
| limit: 20 | ||
| } | ||
| }); | ||
|
|
||
| var tag = argv.tag; | ||
| var limit = argv.limit; | ||
|
|
||
| glob(path.join(pathToJasmineTests, '*.js'), function(err, files) { | ||
| if(err) throw err; | ||
|
|
||
| var file2cnt = {}; | ||
|
There was a problem hiding this comment. to note, with |
||
|
|
||
| files.forEach(function(file) { | ||
| var code = fs.readFileSync(file, 'utf-8'); | ||
| var bn = path.basename(file); | ||
|
|
||
| falafel(code, function(node) { | ||
| if(isTestDescription(node, tag)) { | ||
| if(file2cnt[bn]) { | ||
| file2cnt[bn]++; | ||
| } else { | ||
| file2cnt[bn] = 1; | ||
| } | ||
| } | ||
| }); | ||
| }); | ||
|
|
||
| var ranking = Object.keys(file2cnt); | ||
| var runs = []; | ||
|
|
||
| // if 'it' count in file greater than threshold, | ||
| // run only this file separately, | ||
| // don't try to shard within file | ||
| Object.keys(file2cnt).forEach(function(f) { | ||
| if(file2cnt[f] > limit) { | ||
| runs.push(f); | ||
| ranking.splice(ranking.indexOf(f), 1); | ||
| } | ||
| }); | ||
|
|
||
| // sort ranking in decreasing order | ||
| ranking.sort(function(a, b) { return file2cnt[b] - file2cnt[a]; }); | ||
|
|
||
| var runi; | ||
| var cnt; | ||
|
|
||
| function newRun() { | ||
| var r0 = ranking[0]; | ||
| runi = [r0]; | ||
| cnt = file2cnt[r0]; | ||
| ranking.shift(); | ||
| } | ||
|
|
||
| function concat() { | ||
| runs.push(runi.join(',')); | ||
| } | ||
|
|
||
| // try to match files with many tests with files not-that-many, | ||
| // by matching first rank with one or multiple trailing ranks. | ||
| newRun(); | ||
| while(ranking.length) { | ||
| var rn = ranking[ranking.length - 1]; | ||
|
|
||
| if((cnt + file2cnt[rn]) > limit) { | ||
| concat(); | ||
| newRun(); | ||
| } else { | ||
| runi.push(rn); | ||
| cnt += file2cnt[rn]; | ||
| ranking.pop(); | ||
| } | ||
| } | ||
| concat(); | ||
|
|
||
| // print result to stdout | ||
| console.log(runs.join('\n')); | ||
| }); | ||
|
|
||
| function isTestDescription(node, tag) { | ||
| var isDescription = ( | ||
| node.type === 'Literal' && | ||
| node.parent && | ||
| node.parent.type === 'CallExpression' && | ||
| node.parent.callee && | ||
| node.parent.callee.type === 'Identifier' && | ||
| node.parent.callee.name === 'it' | ||
| ); | ||
|
|
||
| if(!tag) return isDescription; | ||
|
|
||
| return ( | ||
| isDescription && | ||
| node.source().indexOf('@' + tag) !== -1 | ||
| ); | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
node tasks/shard_jasmine_tests.js --tag=gloutputs:which is then converted into a bash array (that's the outer
()) and then looped below.