no more fail for async tests, only failTest #2918
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexcjohnson
commented
Aug 17, 2018
| @@ -2,7 +2,7 @@ var Plotly = require('@lib/index'); | |||
| var createGraphDiv = require('../assets/create_graph_div'); | |||
| var destroyGraphDiv = require('../assets/destroy_graph_div'); | |||
| var textchartMock = require('@mocks/text_chart_arrays.json'); | |||
| var fail = require('../assets/fail_test'); | |||
| var failTest = require('../assets/fail_test'); | |||
There was a problem hiding this comment.
FWIW there was only one actual bug caught in this change, download_test has one real Jasmine fail in it which we were overriding with our async version:
which I guess would still show up as a test failure... it just wouldn't give the right message.
|
@etpinard do you want to use this PR, since it's all about tests, to play with the streamtube test failure? Or make a new one to sort that out? |
Good idea! I'll push a few commits to this branch. |
Merged
|
💃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @etpinard