-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Better polar setConvert + a few misc polar touch ups #2895
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
e9c3ef8
:hocho: obsolete things in Bar.calc
etpinard 80717d5
require doTicksSingle and setConvertCartesian directly
etpinard 3d8eef2
improve polar setConvert
etpinard 87a3920
:hocho: now useless intoCenter line calcdata hack
etpinard 91064ca
add :books: about axes in polar subplots
etpinard 3787bfa
sub angularAxis._id 'angular' -> 'angularaxis'
etpinard 4f881fa
add r0/dr theta0/dtheta
etpinard 449dc43
fix #2888 - clear scene via gl ref in line2d object
etpinard dae3ccd
:hocho: hoveron declaration in scattergl and scatterpolargl
etpinard d3b3615
add on-graph 'text' to scatterpolargl
etpinard ec57a42
fix radial drag when scatterpolar & scatterpolargl are on same subplot
etpinard f5bceda
:hocho: unused keys from angular axis objects
etpinard 0c517d1
use isAngular helper in axes.js
etpinard 4c11c84
improve polar setConvert docstring
etpinard b4700ca
use .filter instead of (confusing) .reduce
etpinard c3044e0
clean up cleanViewport logic
etpinard b81885d
avoid trying to call scene.clear more than once per mousemove
etpinard 75786e4
add fill2d and error2d in clearViewport fallback list
etpinard File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! 📚