Bug null data #286
Merged
Bug null data #286
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| var c = ax._categories.indexOf(v); | ||
| return c===-1 ? constants.BADNUM : c; | ||
| if(v !== null && v !== undefined && ax._categories.indexOf(v) === -1){ |
There was a problem hiding this comment.
nice, maybe we should make that standard: http://eslint.org/docs/rules/no-eq-null
|
Awesome. I'm gonna jump on this branch to add an image test at some before the next release. |
|
👍 |
|
💃 for me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #271.
Real short fix. I'm not too sure where best to put the tests for this one though so I created a new testfile. I'm happy to move them into an existing file if there is a suitable place though.