Scattergeo selection fixups #2827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

etpinard merged 2 commits into master from scattergeo-select-fixups

Jul 23, 2018

Contributor

etpinard commented Jul 19, 2018

fixes a few issues with scattergeo selection:

[un]selected.marker.opacity never got coerced correctly, and no one has reported this before @rmoestl did a few hours ago 😑
some geo projections return [NaN, NaN] when trying to convert bad lon/lat coordinates into pixels, but some others (e.g. robinson -> https://rreusser.github.io/plotly-mock-viewer/#geo_country-names) throw up on bad lon/lat. From now on, we won't take any chances.

etpinard added 2 commits

July 19, 2018 15:07


          coerce scattergeo [un]selected.marker.opacity !

16f9fd2


          fix selection on geo projs that don't handle BADNUMs during c2p

etpinard added bug status: reviewable labels

Collaborator

alexcjohnson commented Jul 21, 2018

Very nice, 💃 Thanks for the report @rmoestl!

etpinard merged commit e1ecd18 into master

etpinard deleted the scattergeo-select-fixups branch

July 23, 2018 13:25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug