Skip to content

Fixup bartext removal in update selections #2689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 4, 2018
Merged

Conversation

etpinard
Copy link
Contributor

@etpinard etpinard commented Jun 1, 2018

fixes #2688 which was a regression since commit 6d88255 where all Bar started using a d3-iomatic update pattern.

cc @alexcjohnson

... when tx item is blank or textposition is 'none'
@etpinard etpinard added bug something broken status: reviewable labels Jun 1, 2018
@alexcjohnson
Copy link
Collaborator

That was quick! Looks great 💃

@etpinard etpinard merged commit da193d7 into master Jun 4, 2018
@etpinard etpinard deleted the fixup-bar-text-removal branch June 4, 2018 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken
Projects
None yet
Development

Successfully merging this pull request may close these issues.

restyle textposition produces javascript error
2 participants