Code

Automargin fixes#2681

Code

Merged

alexcjohnson merged 17 commits intomasterplotly/plotly.js:masterfrom

react-automarginplotly/plotly.js:react-automarginCopy head branch name to clipboard

Jun 6, 2018

Commits

Commits on May 30, 2018

• stop mutating user data to add uids

  Show description for 970db80
  alexcjohnson

  committed
  970db80

  Copy full SHA for 970db80

• some test cleanup

  alexcjohnson

  committed
  26278de

  Copy full SHA for 26278de

• first cut at updating automargin logic

  alexcjohnson

  committed
  6dd68bd

  Copy full SHA for 6dd68bd

• refactor colorbars for simpler connection to trace attributes

  Show description for fa86147
  alexcjohnson

  committed
  fa86147

  Copy full SHA for fa86147

• test legend, rangeselector, rangeslider automargin updates

  alexcjohnson

  committed
  95f9b33

  Copy full SHA for 95f9b33

• provide uids to traces a little earlier - to fix carpet clip ids

  alexcjohnson

  committed
  8f3da82

  Copy full SHA for 8f3da82

• :hocho: colorbar.vals - seems like that was all obsolete anyway

  alexcjohnson

  committed
  f9fbbc6

  Copy full SHA for f9fbbc6

Commits on May 31, 2018

• cleanup in sliders_test

  alexcjohnson

  committed
  222f396

  Copy full SHA for 222f396

Commits on Jun 1, 2018

• simplify inner plot size tests with custom_assertions

  alexcjohnson

  committed
  bd07df7

  Copy full SHA for bd07df7

• fix and test slider x positioning when they push margins

  Show description for 84a5695
  alexcjohnson

  committed
  84a5695

  Copy full SHA for 84a5695

• move sliders to the updated automargin framework

  alexcjohnson

  committed
  3deab4c

  Copy full SHA for 3deab4c

• use bg rect instead of grids for assertPlotSize

  alexcjohnson

  committed
  bb6c720

  Copy full SHA for bb6c720

Commits on Jun 2, 2018

• base fractional colorbar size on post-expanded-margin plot size

  Show description for d02c76b
  alexcjohnson

  committed
  d02c76b

  Copy full SHA for d02c76b

Commits on Jun 6, 2018

• comment and fix on assertPlotSize with margin.pad

  alexcjohnson

  committed
  5d31324

  Copy full SHA for 5d31324

• reduce automargin padding for small explicit margins

  alexcjohnson

  committed
  16ea22a

  Copy full SHA for 16ea22a

• axRange edits don't need drawMarginPushers after all

  Show description for 24aeb7c
  alexcjohnson

  committed
  24aeb7c

  Copy full SHA for 24aeb7c

• automargin comment updates

  alexcjohnson

  committed
  230a782

  Copy full SHA for 230a782