Create two (not three) WebGL contexts for scattergl/splom graphs #2662
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- so that we create two (not three) contexts in scattergl graph as we in versions before 1.36.0
| .then(done); | ||
| }); | ||
|
|
||
| it('should create two WebGL context per graph', function(done) { |
|
Nice, glad it was that easy! 💃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #2614, starting in version 1.36.0 all regl based graphs created 3 WebGL contexts (one for each canvas layer). But one of these layer (the pick layer) is only used in parcoords traces, so we can create two contexts instead of three on scattergl and splom graphs.
Why did this happen? I got sloppy in commit 469e4cd where I failed to bring this
d.pickcheck intoprepareRegl.Reducing the number of WebGL context created does two things:
cc @alexcjohnson @dy