Bye bye browser-pack-flat #2572
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Agreed. Enough is enough. 🔪 💃 |
|
Great. Releasing |
etpinard
added a commit
that referenced
this pull request
May 4, 2018
- something I forgot to do in #2572
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2571 and essentially reverts #2447
browser-pack-flathasn't been nice to us. Although it did took out a several bytes for our dist bundles (and probably some noticeable in-browser compilation speedup), it made us release two broken set of dist bundles:v1.35.0had #2456 andv1.36.0has #2571 - which I'd say pretty bad bugs.I think what we gain from
browser-pack-flatisn't worth the trouble. We should perhaps submit a bug report to https://github.com/goto-bus-stop/browser-pack-flat/issues/new if we find the time.