Skip to content

React finance precursor #2525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Apr 5, 2018
Merged

React finance precursor #2525

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
28d073f
clean up catch/done in plot_api_test
alexcjohnson Apr 3, 2018
c802d79
non-attribute modifications to _fullData should be _private, in carpe…
alexcjohnson Apr 3, 2018
16a22f3
simplify convert_column_xyz API
alexcjohnson Apr 3, 2018
035c98d
have Plotly.react diff _fullInput instead of the final trace
alexcjohnson Apr 3, 2018
95911da
bug in relinkPrivateKeys condition
alexcjohnson Apr 3, 2018
6b201a1
stop overwriting fullTrace arrays in convert_column_xyz
alexcjohnson Apr 4, 2018
5546ec7
stop slicing finance input arrays during supplyDefaults
alexcjohnson Apr 4, 2018
0221510
:hocho: obsolete _xp, _yp from carpet
alexcjohnson Apr 5, 2018
b0af416
even more became obsolete :tada:
alexcjohnson Apr 5, 2018
c2b11dc
failTest in transform_groupby_test
alexcjohnson Apr 5, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/plots/plots.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -380,7 +380,7 @@ plots.supplyDefaults = function(gd) {
if(_module.cleanData) _module.cleanData(newFullData);
}

if(oldFullData.length === newData.length) {
if(oldFullData.length === newFullData.length) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How hard would it be to 🔒 this fix?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was going to add a Plotly.react test in transform_groupby_test for this and diffing on _fullInput, hence c2b11dc, since that's the obvious place where fullData will have a different length from data after finance is converted. But on second thought perhaps that can of worms should wait for #2508? I'll make a note in that issue if you 👍. The fact that all the existing Plotly.react and other tests pass means these didn't cause problems at least.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But on second thought perhaps that can of worms should wait for #2508?

sounds good 👌

for(i = 0; i < newFullData.length; i++) {
relinkPrivateKeys(newFullData[i], oldFullData[i]);
}
Expand Down