-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
React finance precursor #2525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
React finance precursor #2525
Changes from 8 commits
28d073f
c802d79
16a22f3
035c98d
95911da
6b201a1
5546ec7
0221510
b0af416
c2b11dc
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -380,7 +380,7 @@ plots.supplyDefaults = function(gd) { | |
if(_module.cleanData) _module.cleanData(newFullData); | ||
} | ||
|
||
if(oldFullData.length === newData.length) { | ||
if(oldFullData.length === newFullData.length) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. How hard would it be to 🔒 this fix? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I was going to add a There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
sounds good 👌 |
||
for(i = 0; i < newFullData.length; i++) { | ||
relinkPrivateKeys(newFullData[i], oldFullData[i]); | ||
} | ||
|
@@ -2364,14 +2364,15 @@ plots.doCalcdata = function(gd, traces) { | |
// clear stuff that should recomputed in 'regular' loop | ||
if(hasCalcTransform) clearAxesCalc(axList); | ||
|
||
// 'regular' loop | ||
for(i = 0; i < fullData.length; i++) { | ||
var cd = []; | ||
|
||
function calci(i, isContainer) { | ||
trace = fullData[i]; | ||
_module = trace._module; | ||
|
||
if(!!_module.isContainer !== isContainer) return; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ha. Nice fix. I wonder if other carpet-dependent blocks (e.g. here) could be simplified (or at least generatlized) using There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Probably some such blocks could... though I don't see much to do with that |
||
|
||
var cd = []; | ||
|
||
if(trace.visible === true) { | ||
_module = trace._module; | ||
|
||
// keep ref of index-to-points map object of the *last* enabled transform, | ||
// this index-to-points map object is required to determine the calcdata indices | ||
|
@@ -2406,6 +2407,11 @@ plots.doCalcdata = function(gd, traces) { | |
calcdata[i] = cd; | ||
} | ||
|
||
// 'regular' loop - make sure container traces (eg carpet) calc before | ||
// contained traces (eg contourcarpet) | ||
for(i = 0; i < fullData.length; i++) calci(i, true); | ||
for(i = 0; i < fullData.length; i++) calci(i, false); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Because I moved |
||
|
||
Registry.getComponentMethod('fx', 'calc')(gd); | ||
}; | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
similarly here, can we 🔒 this thing?