Bring back geo trace toggle [fixes #244] #245
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- geo plot routine use a classic d3 join/enter/exit pattern - trace visibility is updated using exit selections - to simplify the logic, send only visible trace to the geo plot routine so that visible traces and svg trace groups match one to one.
| var traceKey = traceKeys[j]; | ||
| Plots.getModule(traceKey).plot(this, traceData[traceKey], geoLayout); | ||
| var moduleData = traceData[traceKeys[j]]; | ||
| var _module = moduleData[0]._module; |
There was a problem hiding this comment.
@mdtusz sorry for sneaking this in here.
I believe grabbing _module from the trace objects is more robust then relying on Plots. That way, a plot's required trace modules are scoped inside each plot state, instead of being library-wide globals.
|
Definitely a better way to go about it. 💃 |
etpinard
added a commit
that referenced
this pull request
Feb 9, 2016
Bring back geo trace toggle [fixes #244]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mdtusz
Visibility toggling for geo traces has been broken since e8ebcb2
This PR fixes it and adds tests.