Skip to content

multiple selections on parcoords axes #2415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 26 commits into from
Mar 21, 2018
Merged

multiple selections on parcoords axes #2415

Changes from 1 commit
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
9208cc3
- factored out brushing
monfera Feb 5, 2018
40b0c2b
- full refactor of shader code, DRY, optimizations etc.
monfera Mar 3, 2018
7f507c3
remove constraintrange from parcoords mocks
alexcjohnson Mar 6, 2018
d25d261
tweak the parcoords constraint grabber ranges
alexcjohnson Mar 9, 2018
367e294
parcoords constraint cleanup
alexcjohnson Mar 12, 2018
1030542
dimension.multiselect boolean attr
alexcjohnson Mar 12, 2018
c046397
Merge branch 'master' into parcoords-multiselect-squashed
alexcjohnson Mar 12, 2018
a4f4a5f
info_array dimensions='1-2'
alexcjohnson Mar 13, 2018
a78db76
finalize multiselect functionality
alexcjohnson Mar 15, 2018
01ba11e
:hocho: fdescribe
alexcjohnson Mar 15, 2018
68e9e48
lint axisbrush
alexcjohnson Mar 15, 2018
cb00901
fail -> failTest - fail is a jasmine global
alexcjohnson Mar 15, 2018
f2690ac
fix one more filter bug, refactor parcoords test to hopefully reuse c…
alexcjohnson Mar 15, 2018
ec44922
refactor more of parcoords test to use Plotly.react
alexcjohnson Mar 15, 2018
352a884
parentElement -> parentNode
alexcjohnson Mar 15, 2018
57085e1
shorten parcoords snap tweening during tests
alexcjohnson Mar 15, 2018
fff668a
@flaky on ordinal constraint snap test
alexcjohnson Mar 15, 2018
6fe2d79
I give up... @noCI my new tests
alexcjohnson Mar 15, 2018
2911ae6
:hocho: parcoords memory leak
alexcjohnson Mar 16, 2018
fa1a436
parcoords create/update pattern
alexcjohnson Mar 16, 2018
0e75c5a
parcoords test cleanup
alexcjohnson Mar 16, 2018
a7bd686
click to select an ordinal value
alexcjohnson Mar 17, 2018
6432b89
cleanup, and remove some obsolete code
alexcjohnson Mar 17, 2018
03d8779
tweaked parcoords mocks
alexcjohnson Mar 19, 2018
f147644
Revert "tweaked parcoords mocks"
alexcjohnson Mar 19, 2018
c3cc927
fix bug introduced in cleanup
alexcjohnson Mar 19, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
64 changes: 32 additions & 32 deletions test/jasmine/tests/parcoords_test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ var attributes = require('@src/traces/parcoords/attributes');
var createGraphDiv = require('../assets/create_graph_div');
var delay = require('../assets/delay');
var destroyGraphDiv = require('../assets/destroy_graph_div');
var fail = require('../assets/fail_test');
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI fail is a jasmine global, we were overloading it here, so among other things if you don't bring in assets/fail_test but you thought you had, linters won't catch it. We should probably change that in the rest of our test suites too...

var failTest = require('../assets/fail_test');
var mouseEvent = require('../assets/mouse_event');
var supplyAllDefaults = require('../assets/supply_defaults');

Expand Down Expand Up @@ -318,7 +318,7 @@ describe('@gl parcoords', function() {
expect(gd.data[0].dimensions[1].range).toEqual([0, 700000]);
expect(gd.data[0].dimensions[1].constraintrange).not.toBeDefined();
})
.catch(fail)
.catch(failTest)
.then(done);
});

Expand All @@ -337,7 +337,7 @@ describe('@gl parcoords', function() {
expect(gd.data[0].dimensions[0].constraintrange).toBeDefined();
expect(gd.data[0].dimensions[0].constraintrange).toEqual([200, 700]);
})
.catch(fail)
.catch(failTest)
.then(done);
});

Expand All @@ -352,7 +352,7 @@ describe('@gl parcoords', function() {
expect(gd.data[0].dimensions.length).toEqual(0);
expect(document.querySelectorAll('.axis').length).toEqual(0);
})
.catch(fail)
.catch(failTest)
.then(done);
});

Expand All @@ -370,7 +370,7 @@ describe('@gl parcoords', function() {
expect(gd.data[0].dimensions.length).toEqual(2);
expect(document.querySelectorAll('.axis').length).toEqual(2);
})
.catch(fail)
.catch(failTest)
.then(done);
});

Expand Down Expand Up @@ -398,7 +398,7 @@ describe('@gl parcoords', function() {
expect(document.querySelectorAll('.axis').length).toEqual(2);
expect(gd.data[0].dimensions[0].values.length).toEqual(1);
})
.catch(fail)
.catch(failTest)
.then(done);
});

Expand All @@ -423,7 +423,7 @@ describe('@gl parcoords', function() {
expect(document.querySelectorAll('.axis').length).toEqual(0);
expect(gd.data[0].dimensions[0].values.length).toEqual(0);
})
.catch(fail)
.catch(failTest)
.then(done);
});

Expand Down Expand Up @@ -452,7 +452,7 @@ describe('@gl parcoords', function() {
expect(document.querySelectorAll('.axis').length).toEqual(2);
expect(gd.data[0].dimensions[0].values.length).toEqual(values[0].length);
})
.catch(fail)
.catch(failTest)
.then(done);
});

Expand Down Expand Up @@ -483,7 +483,7 @@ describe('@gl parcoords', function() {
expect(gd.data[0].dimensions.length).toEqual(60);
expect(document.querySelectorAll('.axis').length).toEqual(60);
})
.catch(fail)
.catch(failTest)
.then(done);
});

Expand Down Expand Up @@ -512,7 +512,7 @@ describe('@gl parcoords', function() {
expect(gd.data[0].dimensions.length).toEqual(60);
expect(document.querySelectorAll('.axis').length).toEqual(60);
})
.catch(fail)
.catch(failTest)
.then(done);
});

Expand Down Expand Up @@ -542,7 +542,7 @@ describe('@gl parcoords', function() {
expect(gd.data[0].dimensions.length).toEqual(60);
expect(document.querySelectorAll('.axis').length).toEqual(60);
})
.catch(fail)
.catch(failTest)
.then(done);
});

Expand Down Expand Up @@ -576,7 +576,7 @@ describe('@gl parcoords', function() {
expect(gd.data[0].dimensions.length).toEqual(5); // it's still five, but ...
expect(document.querySelectorAll('.axis').length).toEqual(3); // only 3 axes shown
})
.catch(fail)
.catch(failTest)
.then(done);
});

Expand All @@ -595,7 +595,7 @@ describe('@gl parcoords', function() {
};
gd = createGraphDiv();
Plotly.plot(gd, mockCopy.data, mockCopy.layout)
.catch(fail)
.catch(failTest)
.then(done);
});

Expand Down Expand Up @@ -642,7 +642,7 @@ describe('@gl parcoords', function() {

expect(document.querySelectorAll('.axis').length).toEqual(20); // one dimension is `visible: false`
})
.catch(fail)
.catch(failTest)
.then(done);

});
Expand All @@ -662,7 +662,7 @@ describe('@gl parcoords', function() {
expect(gd.data[0].dimensions[0].constraintrange).toEqual([100000, 150000]);
expect(gd.data[0].dimensions[1].constraintrange).not.toBeDefined();
})
.catch(fail)
.catch(failTest)
.then(done);

});
Expand All @@ -689,7 +689,7 @@ describe('@gl parcoords', function() {
.then(restyleDimension('constraintrange', [[0, 1]]))
.then(restyleDimension('values', [[0, 0.1, 0.4, 1, 2, 0, 0.1, 0.4, 1, 2]]))
.then(restyleDimension('visible', false))
.catch(fail)
.catch(failTest)
.then(done);
});

Expand All @@ -711,7 +711,7 @@ describe('@gl parcoords', function() {
expect(gd.data[0].dimensions[0].constraintrange).toEqual([100000, 150000]);
expect(gd.data[0].dimensions[1].constraintrange).not.toBeDefined();
})
.catch(fail)
.catch(failTest)
.then(done);
});

Expand All @@ -736,7 +736,7 @@ describe('@gl parcoords', function() {
.then(function() {
expect(tester.get()).toBe(true);
})
.catch(fail)
.catch(failTest)
.then(done);

});
Expand Down Expand Up @@ -785,7 +785,7 @@ describe('@gl parcoords', function() {

}, 20);
})
.catch(fail)
.catch(failTest)
.then(done);

});
Expand All @@ -806,7 +806,7 @@ describe('@gl parcoords', function() {
expect(gd.data[0].dimensions[0].constraintrange).toEqual([100000, 150000]);
expect(gd.data[0].dimensions[1].constraintrange).not.toBeDefined();
})
.catch(fail)
.catch(failTest)
.then(done);
});

Expand All @@ -826,7 +826,7 @@ describe('@gl parcoords', function() {
expect(gd.data[0].dimensions[0].constraintrange).toEqual([100000, 150000]);
expect(gd.data[0].dimensions[1].constraintrange).not.toBeDefined();
})
.catch(fail)
.catch(failTest)
.then(done);
});

Expand Down Expand Up @@ -865,7 +865,7 @@ describe('@gl parcoords', function() {
values: [1, 4]
});
})
.catch(fail)
.catch(failTest)
.then(done);
});
});
Expand All @@ -888,7 +888,7 @@ describe('@gl parcoords', function() {
expect(gd.data.length).toEqual(0);
});
})
.catch(fail)
.catch(failTest)
.then(done);
});

Expand Down Expand Up @@ -922,7 +922,7 @@ describe('@gl parcoords', function() {
expect(document.querySelectorAll('.y-axis').length).toEqual(0);
expect(gd.data.length).toEqual(0);
})
.catch(fail)
.catch(failTest)
.then(done);
});

Expand Down Expand Up @@ -953,7 +953,7 @@ describe('@gl parcoords', function() {
expect(foundPixel).toEqual(false);
});
})
.catch(fail)
.catch(failTest)
.then(done);
});

Expand Down Expand Up @@ -985,7 +985,7 @@ describe('@gl parcoords', function() {
expect(document.querySelectorAll('.gl-container').length).toEqual(1);
expect(gd.data.length).toEqual(2);
})
.catch(fail)
.catch(failTest)
.then(done);
});

Expand All @@ -1012,7 +1012,7 @@ describe('@gl parcoords', function() {
expect(document.querySelectorAll('.gl-container').length).toEqual(1);
expect(gd.data.length).toEqual(2);
})
.catch(fail)
.catch(failTest)
.then(done);
});

Expand Down Expand Up @@ -1060,7 +1060,7 @@ describe('@gl parcoords', function() {
expect(document.querySelectorAll('.gl-container').length).toEqual(1);
expect(gd.data.length).toEqual(1);
})
.catch(fail)
.catch(failTest)
.then(done);
});
});
Expand All @@ -1087,7 +1087,7 @@ describe('@gl parcoords', function() {
height: 400,
margin: {t: 100, b: 100, l: 100, r: 100}
})
.catch(fail)
.catch(failTest)
.then(done);
});

Expand Down Expand Up @@ -1162,7 +1162,7 @@ describe('@gl parcoords', function() {
expect(newDashArray.split(',').length).toBe(6, newDashArray);
expect(gd.data[0].dimensions[0].constraintrange).toBeCloseTo2DArray([[0.75, 2.25], [2.75, 4]]);
})
.catch(fail)
.catch(failTest)
.then(done);
});

Expand Down Expand Up @@ -1205,7 +1205,7 @@ describe('@gl parcoords', function() {
// TODO: ideally this would get clipped to [0, 9]...
expect(gd.data[0].dimensions[1].constraintrange).toBeCloseToArray([-0.1020, 9]);
})
.catch(fail)
.catch(failTest)
.then(done);
});

Expand Down Expand Up @@ -1242,7 +1242,7 @@ describe('@gl parcoords', function() {
expect(newDashArray.split(',').length).toBe(6, newDashArray);
expect(gd.data[0].dimensions[0].constraintrange).toBeCloseTo2DArray([[0.75, 1.25], [2.75, 4]]);
})
.catch(fail)
.catch(failTest)
.then(done);
});
});
Expand Down