Skip to content

Minor changes to animation code ahead of the array animation fix #2313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Feb 5, 2018
Merged

Minor changes to animation code ahead of the array animation fix #2313

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
09924a6
minor: stop emitting warnings after having reached a count
monfera Jan 29, 2018
6efb0a7
minor: deleting code block that doesn't seem to have a current purpose
monfera Jan 30, 2018
6d4c86b
making the warning invocation counting global, rather than per `addFr…
monfera Feb 4, 2018
1fb2ed1
test case for warning invocations
monfera Feb 4, 2018
a666251
Merge branch 'master' into array-anim
monfera Feb 4, 2018
b1e538d
Check for numeric - text name collisions within frames of a single `a…
monfera Feb 4, 2018
1ccf35c
Moved test to frame_api_test.js
monfera Feb 4, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions src/plots/plots.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2252,14 +2252,6 @@ plots.transition = function(gd, data, layout, traces, frameOpts, transitionOpts)
var module = contFull._module;

if(!module) continue;

if(!module.animatable) {
var thisUpdate = {};

for(var ai in data[i]) {
thisUpdate[ai] = [data[i][ai]];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strange. I wonder what Ricky had in mind here. Good catch 👌

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could've been just some initial logic that remained there.

}
}
}

var seq = [plots.previousPromises, interruptPreviousTransitions, prepareTransitions, plots.rehover, executeTransitions];
Expand Down