Skip to content

Split up axes module #230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Feb 2, 2016
Merged

Split up axes module #230

merged 10 commits into from
Feb 2, 2016

Conversation

etpinard
Copy link
Contributor

@etpinard etpinard commented Feb 1, 2016

@mdtusz @alexcjohnson @cldougl

... to hopefully one day remove Axes from the core plotly module.

@etpinard etpinard added this to the subplotly.js milestone Feb 1, 2016
@etpinard
Copy link
Contributor Author

etpinard commented Feb 1, 2016

I put all the new files in src/plots/cartesian/ directly (i.e. without making a new directory within src/plots/cartesian/.

I didn't see the need for adding one more level to our directory structure. But, this means that we will end up with probably ~20 files under src/plots/cartesian/ when axes.js will be completely split up.

Thoughts?

@mdtusz
Copy link
Contributor

mdtusz commented Feb 2, 2016

Looks ok to me.

💃

etpinard added a commit that referenced this pull request Feb 2, 2016
@etpinard etpinard merged commit 21b5411 into master Feb 2, 2016
@etpinard etpinard deleted the split-up-axes branch February 2, 2016 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants