Skip to content

Unlock gl-shader #2293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 26, 2018
Merged

Unlock gl-shader #2293

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7b1bb6a
Setup deps
dy Jan 25, 2018
1fa2f0a
Fix versions
dy Jan 25, 2018
0d1d19b
Remove gl-axes3d package
dy Jan 25, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,18 +69,19 @@
"es6-promise": "^3.0.2",
"fast-isnumeric": "^1.1.1",
"font-atlas-sdf": "^1.3.3",
"gl-axes3d": "^1.2.6",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are we adding a package but making no direct reference to it?

Copy link
Contributor Author

@dy dy Jan 25, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexcjohnson good point. I wonder if we should remove gl-shader dependency as well, since we're not using it by plotly directly. @etpinard had it fixed version at the root level to ensure that all components use the same gl-shader. But that is no more relevant since now on.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds reasonable to me, but after the mess we had yesterday with npm ls I'd like to figure this out with @etpinard 's input.

"gl-contour2d": "^1.1.2",
"gl-error3d": "^1.0.6",
"gl-error3d": "^1.0.7",
"gl-heatmap2d": "^1.0.3",
"gl-line3d": "^1.1.0",
"gl-line3d": "^1.1.1",
"gl-mat4": "^1.1.2",
"gl-mesh3d": "^1.3.0",
"gl-mesh3d": "^1.3.1",
"gl-plot2d": "^1.3.0",
"gl-plot3d": "^1.5.4",
"gl-pointcloud2d": "^1.0.0",
"gl-scatter3d": "^1.0.4",
"gl-select-box": "^1.0.1",
"gl-shader": "4.2.0",
"gl-shader": "^4.2.1",
"gl-spikes2d": "^1.0.1",
"gl-surface3d": "^1.3.1",
"has-hover": "^1.0.1",
Expand Down