Skip to content

Heatmap equal gaps #2213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 18, 2017
Merged

Heatmap equal gaps #2213

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2802c79
update heatmap brick padding mock to show the problem
alexcjohnson Dec 18, 2017
0d1709b
fix heatmap gap algo: uniform gaps, all bricks centered on their data
alexcjohnson Dec 18, 2017
6f90335
longer timeout for choropleth bundle test
alexcjohnson Dec 18, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 16 additions & 6 deletions test/jasmine/bundle_tests/choropleth_test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,24 +5,34 @@ var PlotlyChoropleth = require('@lib/choropleth');

var createGraphDiv = require('../assets/create_graph_div');
var destroyGraphDiv = require('../assets/destroy_graph_div');
var failTest = require('../assets/fail_test');

var LONG_TIMEOUT_INTERVAL = 5 * jasmine.DEFAULT_TIMEOUT_INTERVAL;


describe('Bundle with choropleth', function() {
'use strict';

Plotly.register(PlotlyChoropleth);

var gd;

var mock = require('@mocks/geo_multiple-usa-choropleths.json');

beforeEach(function(done) {
Plotly.plot(createGraphDiv(), mock.data, mock.layout).then(done);
beforeEach(function() {
gd = createGraphDiv();
});

afterEach(destroyGraphDiv);

it('should graph choropleth traces', function() {
var nodes = d3.selectAll('g.trace.choropleth');
it('should graph choropleth traces', function(done) {
Plotly.plot(gd, mock.data, mock.layout)
.then(function() {
var nodes = d3.selectAll('g.trace.choropleth');

expect(nodes.size()).toEqual(4);
});
expect(nodes.size()).toEqual(4);
})
.catch(failTest)
.then(done);
}, LONG_TIMEOUT_INTERVAL);
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've seen this one fail a lot - and this morning seems like circle is super stressed or something, every intermittent test failure we've ever had seems to be biting us today. Choropleth needs to make a request for map data - it's local but still perhaps slow? Just give it some more time before we fail.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's local but still perhaps slow?

Actually, no. Geo subplots in jasmine tests get their map data from https://cdn.plot.ly/world_110m.json and friends.

You brought this up previously (see #163) but I never got around to fixing that.

👌 for bumping the timeout interval.

});