yet another contour algorithm bug fix #2091
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah crap - it's not that simple 😢 |
- and move the test to an image, since it passed before and after this change
alexcjohnson
commented
Oct 17, 2017
| pi.edgepaths[edgei2] = | ||
| pi.edgepaths[edgei2].concat(pts, edgepath2); | ||
| if(j > i) j--; | ||
| pi.edgepaths[j] = edgepathj.concat(pts, edgepathi); |
There was a problem hiding this comment.
in the end it was all about these two lines - getting the right index (if(j > i) j--;) and using the right paths (previously we were doubling up edgepath2 <-> edgepathj but because of the poor usage it was hard to tell that. Surprising that we hadn't hit this before in our tests, but now we do!
There was a problem hiding this comment.
Nice! Then this also applies to carpet contour plots which use the same function. 🎉
|
Nicely done 💃 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm always amazed how many edge cases (literal edge cases in fact 🖼 ) there are with contour plots, and that our tests still hadn't (is that too optimistic a word? should I say haven't?) covered them all.
Fixes #2088