Skip to content

fix Chinese formatDate error on npm start #2069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 6, 2017
Merged

fix Chinese formatDate error on npm start #2069

merged 1 commit into from
Oct 6, 2017

Conversation

Handsome2734
Copy link
Contributor

Fix formatDate error on npm start when system language is Chinese. #1630

@alexcjohnson
Copy link
Collaborator

Thanks! I bet for compatibility with any arbitrary language we could do something even more permissive like /\(([^\(\)]*\)\)/ - or even drop the timezone, it's not the most crucial bit of info there. But I'm glad this fixes it for Chinese anyway. 💃

@alexcjohnson alexcjohnson merged commit 63c163c into plotly:master Oct 6, 2017
@alexcjohnson alexcjohnson mentioned this pull request Oct 6, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Handsome2734 @alexcjohnson