Annotations offline #2046
Merged
Annotations offline #2046
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
at one point I envisioned this as a more general routine, to add heads to any line and we could still do that, but other uses will just need to follow the same naming.
instead of hard-coding these in drawArrowHead
etpinard
suggested changes
Oct 2, 2017
src/plots/plots.js
Outdated
| @@ -212,7 +212,12 @@ plots.redrawText = function(gd) { | |||
| plots.resize = function(gd) { | |||
| return new Promise(function(resolve, reject) { | |||
|
|
|||
| if(!gd || d3.select(gd).style('display') === 'none') { | |||
| function isHidden(gd) { | |||
| var display = getComputedStyle(gd).display; | |||
There was a problem hiding this comment.
I'd prefer window.getComputedStyle here.
There was a problem hiding this comment.
... in an effort to make plotly.js work in jsdom
There was a problem hiding this comment.
and readability (I think).
| if(!msg) msg = ''; | ||
|
|
||
| var path = g.select('path').node(); | ||
| expect(getComputedStyle(path).fill).toBe(expectation.bgcolor, msg + ': bgcolor'); |
There was a problem hiding this comment.
... but this is in a test file. I don't care about that as much. Your call.
| .toEqual(opacity[i], 'to have correct pt opacity'); | ||
| }); | ||
| }); | ||
| }; | ||
|
|
||
| exports.assertHoverLabelStyle = function(g, expectation, msg, textSelector) { |
etpinard
approved these changes
Oct 2, 2017
|
Nicely done 💃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supposed to be a quick Friday night bugfix but it turned a bit more involved:
drawArrowHeada bit.strict-d3) that we don't useselection.styleas a getter there or anywhere else.selection.styleas a getter - some others actually could cause bugs of their own (like incolorbar.draw), some were benign (if they dealt with eg hover labels so we know the element is displayed) but it's easier - and in some cases simpler code even - to just be consistent in not using it.cc @etpinard