Sankey tooltip calc relative to div.svg-container rather than gd #2027
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
monfera
force-pushed
the
sankey-margined-tooltip
branch
from
b4e6aa2 to
1658829
Compare
|
Looks good, thanks - 💃 I'll also make an issue over in streambed for us to stop diving into sub-elements of the plot Note though that at some point we need to find alternatives to all of these |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes remaining issue of #2014
The fix is that Sankey tooltip positioning be relative to
div.svg-containerrather thangd, a difference that's significant if there's a margin specified on (or is effective on)div.svg-container.