Skip to content

Fix hover label exponent hiding or gl3d log hover #1949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 15, 2017
Merged

Conversation

rreusser
Copy link
Contributor

@rreusser rreusser commented Aug 11, 2017

This PR fixes the gl3d hover issue caused and not caught by #1932. It also adds a test to regular log scatter since there's nothing gl-specific about the failure, just that it wasn't tested in regular scatter.

@etpinard etpinard added status: reviewable bug something broken labels Aug 14, 2017
@etpinard
Copy link
Contributor

💃 Looking good! Thanks!


By the way @rreusser , were you able to run npm run test-jasmine -- gl_plot_interact successfully on your machine?

@rreusser
Copy link
Contributor Author

rreusser commented Aug 14, 2017

@etpinard is there a good way to test that? gl_plot_interact throws lots of errors that seem to be mostly pixel positioning errors that aren't new, which makes it a bit tricky to determine what's actually failing without careful git-bisect:

ERROR: 'TypeError: Cannot read property '0' of undefined
    at assertHoverText (http://localhost:9876/absolute/var/folders/5s/mm8_jrls0zd34zkb1z71xb940000gp/T/7778d768814311101fc1bb985c239966.browserify?f472e31a0c1013acf826f33e432a4a5e7b4208f0:186456:21)
    at http://localhost:9876/absolute/var/folders/5s/mm8_jrls0zd34zkb1z71xb940000gp/T/7778d768814311101fc1bb985c239966.browserify?f472e31a0c1013acf826f33e432a4a5e7b4208f0:186523:13
    at <anonymous>'
Chrome 60.0.3112 (Mac OS X 10.12.6) Test gl3d plots @noCI should display correct hover labels and emit correct event data (scatter3d case) FAILED
	Expected 0 to equal 1.
	    at assertHoverText (/var/folders/5s/mm8_jrls0zd34zkb1z71xb940000gp/T/tests/gl_plot_interact_test.js:37:0 <- /var/folders/5s/mm8_jrls0zd34zkb1z71xb940000gp/T/7778d768814311101fc1bb985c239966.browserify:186453:29)
	    at /var/folders/5s/mm8_jrls0zd34zkb1z71xb940000gp/T/tests/gl_plot_interact_test.js:107:0 <- /var/folders/5s/mm8_jrls0zd34zkb1z71xb940000gp/T/7778d768814311101fc1bb985c239966.browserify:186523:13
	    at <anonymous>
	Expected TypeError: Cannot read property '0' of undefined to be undefined.
	    at failTest (/var/folders/5s/mm8_jrls0zd34zkb1z71xb940000gp/T/assets/fail_test.js:24:0 <- /var/folders/5s/mm8_jrls0zd34zkb1z71xb940000gp/T/7778d768814311101fc1bb985c239966.browserify:186343:23)
	    at <anonymous>
Chrome 60.0.3112 (Mac OS X 10.12.6) Test gl3d plots @noCI should emit correct event data on click (scatter3d case) FAILED
	Expected [  ] to equal <jasmine.arrayContaining([ 'x', 'y', 'z', 'data', 'fullData', 'curveNumber', 'pointNumber' ])>.
	    at assertEventData (/var/folders/5s/mm8_jrls0zd34zkb1z71xb940000gp/T/tests/gl_plot_interact_test.js:63:0 <- /var/folders/5s/mm8_jrls0zd34zkb1z71xb940000gp/T/7778d768814311101fc1bb985c239966.browserify:186479:37)
	    at /var/folders/5s/mm8_jrls0zd34zkb1z71xb940000gp/T/tests/gl_plot_interact_test.js:286:0 <- /var/folders/5s/mm8_jrls0zd34zkb1z71xb940000gp/T/7778d768814311101fc1bb985c239966.browserify:186702:13
	    at <anonymous>
	Expected undefined to equal 140.72.
	    at assertEventData (/var/folders/5s/mm8_jrls0zd34zkb1z71xb940000gp/T/tests/gl_plot_interact_test.js:68:0 <- /var/folders/5s/mm8_jrls0zd34zkb1z71xb940000gp/T/7778d768814311101fc1bb985c239966.browserify:186484:26)
	    at /var/folders/5s/mm8_jrls0zd34zkb1z71xb940000gp/T/tests/gl_plot_interact_test.js:286:0 <- /var/folders/5s/mm8_jrls0zd34zkb1z71xb940000gp/T/7778d768814311101fc1bb985c239966.browserify:186702:13
	    at <anonymous>
	Expected undefined to equal -96.97.
	    at assertEventData (/var/folders/5s/mm8_jrls0zd34zkb1z71xb940000gp/T/tests/gl_plot_interact_test.js:69:0 <- /var/folders/5s/mm8_jrls0zd34zkb1z71xb940000gp/T/7778d768814311101fc1bb985c239966.browserify:186485:26)
	    at /var/folders/5s/mm8_jrls0zd34zkb1z71xb940000gp/T/tests/gl_plot_interact_test.js:286:0 <- /var/folders/5s/mm8_jrls0zd34zkb1z71xb940000gp/T/7778d768814311101fc1bb985c239966.browserify:186702:13
	    at <anonymous>
	Expected undefined to equal -96.97.
	    at assertEventData (/var/folders/5s/mm8_jrls0zd34zkb1z71xb940000gp/T/tests/gl_plot_interact_test.js:70:0 <- /var/folders/5s/mm8_jrls0zd34zkb1z71xb940000gp/T/7778d768814311101fc1bb985c239966.browserify:186486:26)
	    at /var/folders/5s/mm8_jrls0zd34zkb1z71xb940000gp/T/tests/gl_plot_interact_test.js:286:0 <- /var/folders/5s/mm8_jrls0zd34zkb1z71xb940000gp/T/7778d768814311101fc1bb985c239966.browserify:186702:13
	    at <anonymous>
	Expected undefined to equal 0.
	    at assertEventData (/var/folders/5s/mm8_jrls0zd34zkb1z71xb940000gp/T/tests/gl_plot_interact_test.js:71:0 <- /var/folders/5s/mm8_jrls0zd34zkb1z71xb940000gp/T/7778d768814311101fc1bb985c239966.browserify:186487:36)
	    at /var/folders/5s/mm8_jrls0zd34zkb1z71xb940000gp/T/tests/gl_plot_interact_test.js:286:0 <- /var/folders/5s/mm8_jrls0zd34zkb1z71xb940000gp/T/7778d768814311101fc1bb985c239966.browserify:186702:13
	    at <anonymous>
	Expected undefined to equal 2.
	    at assertEventData (/var/folders/5s/mm8_jrls0zd34zkb1z71xb940000gp/T/tests/gl_plot_interact_test.js:72:0 <- /var/folders/5s/mm8_jrls0zd34zkb1z71xb940000gp/T/7778d768814311101fc1bb985c239966.browserify:186488:36)
	    at /var/folders/5s/mm8_jrls0zd34zkb1z71xb940000gp/T/tests/gl_plot_interact_test.js:286:0 <- /var/folders/5s/mm8_jrls0zd34zkb1z71xb940000gp/T/7778d768814311101fc1bb985c239966.browserify:186702:13
	    at <anonymous>
Chrome 60.0.3112 (Mac OS X 10.12.6) Test gl3d plots should be able to reversibly change trace type FAILED
	Expected object not to have properties
	    zaxis: Object({ type: 'log' })
	    at /var/folders/5s/mm8_jrls0zd34zkb1z71xb940000gp/T/tests/gl_plot_interact_test.js:299:0 <- /var/folders/5s/mm8_jrls0zd34zkb1z71xb940000gp/T/7778d768814311101fc1bb985c239966.browserify:186715:37
	    at <anonymous>
	Expected object not to have properties
	    zaxis: Object({ type: 'log' })
	    at /var/folders/5s/mm8_jrls0zd34zkb1z71xb940000gp/T/tests/gl_plot_interact_test.js:309:0 <- /var/folders/5s/mm8_jrls0zd34zkb1z71xb940000gp/T/7778d768814311101fc1bb985c239966.browserify:186725:37
	    at <anonymous>
	Expected object not to have properties
	    zaxis: Object({ type: 'log' })
	    at /var/folders/5s/mm8_jrls0zd34zkb1z71xb940000gp/T/tests/gl_plot_interact_test.js:319:0 <- /var/folders/5s/mm8_jrls0zd34zkb1z71xb940000gp/T/7778d768814311101fc1bb985c239966.browserify:186735:37
	    at <anonymous>
Chrome 60.0.3112 (Mac OS X 10.12.6) Test gl2d interactions data-referenced annotations should update on drag FAILED
	Expected 313 to be close to 315 within 1.5 
	    at assertAnnotation (/var/folders/5s/mm8_jrls0zd34zkb1z71xb940000gp/T/tests/gl_plot_interact_test.js:1337:0 <- /var/folders/5s/mm8_jrls0zd34zkb1z71xb940000gp/T/7778d768814311101fc1bb985c239966.browserify:187753:33)
	    at /var/folders/5s/mm8_jrls0zd34zkb1z71xb940000gp/T/tests/gl_plot_interact_test.js:1353:0 <- /var/folders/5s/mm8_jrls0zd34zkb1z71xb940000gp/T/7778d768814311101fc1bb985c239966.browserify:187769:13
	    at <anonymous>
	Expected 263 to be close to 265 within 1.5 
	    at assertAnnotation (/var/folders/5s/mm8_jrls0zd34zkb1z71xb940000gp/T/tests/gl_plot_interact_test.js:1337:0 <- /var/folders/5s/mm8_jrls0zd34zkb1z71xb940000gp/T/7778d768814311101fc1bb985c239966.browserify:187753:33)
	    at /var/folders/5s/mm8_jrls0zd34zkb1z71xb940000gp/T/tests/gl_plot_interact_test.js:1356:0 <- /var/folders/5s/mm8_jrls0zd34zkb1z71xb940000gp/T/7778d768814311101fc1bb985c239966.browserify:187772:13
	    at <anonymous>
Chrome 60.0.3112 (Mac OS X 10.12.6): Executed 35 of 35 (4 FAILED) (18.173 secs / 18.143 secs)

@etpinard
Copy link
Contributor

etpinard commented Aug 15, 2017

throws lots of errors that seem to be mostly pixel positioning errors

No big deal here. Looks like the pixel positions needed to trigger hover events aren't the same on all machines. We should perhaps start making our hover tests pixel-position-agnostic like in this suite, but that's for another day.

💃

@rreusser rreusser merged commit a55cadd into master Aug 15, 2017
@etpinard etpinard deleted the fix-gl3d-hover branch January 11, 2018 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants