-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Fix hover label exponent hiding or gl3d log hover #1949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
💃 Looking good! Thanks! By the way @rreusser , were you able to run |
@etpinard is there a good way to test that?
|
No big deal here. Looks like the pixel positions needed to trigger hover events aren't the same on all machines. We should perhaps start making our hover tests pixel-position-agnostic like in this suite, but that's for another day. 💃 |
This PR fixes the gl3d hover issue caused and not caught by #1932. It also adds a test to regular log scatter since there's nothing gl-specific about the failure, just that it wasn't tested in regular scatter.