Remove explict dependency on Pie module from plot routine #187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- not necessary but better for consistency while deconstructing the modules object.
- this didn't cause any errors, but is unnecessary.
| if(cdPie.length) Pie.plot(gd, cdPie); | ||
| // now draw stuff not on subplots (ie, only pies at the moment) | ||
| if(fullLayout._hasPie) { | ||
| var Pie = Plots.modules.pie._module; |
There was a problem hiding this comment.
Should we maybe use Plots.getModule('pie') here instead for the sake of uniform access?
There was a problem hiding this comment.
good call. Thanks!
|
💃 |
etpinard
added a commit
that referenced
this pull request
Jan 19, 2016
Remove explict dependency on Pie module from plot routine
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mdtusz
I found a simple way to remove the explicit dependency on
Piein plot_api.js meaning thatPiewon't have to be part of core module.