Update Descriptions for Colorscale #186
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdtusz
changed the title
mdtusz
changed the title
|
Seems that the tests on Circle failed because of the server failing to start/connect again. |
| description: [ | ||
| 'Sets the colorscale.', | ||
| 'The colorscale must be an array containing', | ||
| 'arrays mapping a normalized value to an rgb color. At minimum, a', |
There was a problem hiding this comment.
It doesn't have to be an rgb color. rgba, hex, hsl should be fine as described here
There was a problem hiding this comment.
If you're down, I would add:
To control the bounds of the colorscale in z space, use
zminandzmax.
|
💃 |
mdtusz
added a commit
that referenced
this pull request
Jan 18, 2016
Update Descriptions for Colorscale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #178. I'm not 100% sure if this is in the right place, and you may have a better way to word the description. Quick pr though.
Also changed: the
compress_attributesregex for string arrays that arejoined. This will allow for any content in the string (before,[and]would break it.