Replace json assets by js files #183
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- so that webpack won't have to worry about adding a json loader to use plotly.js
|
TODO:
|
etpinard
changed the title
| 'diamond-open': '◇', | ||
| cross: '+', | ||
| x: '❌' | ||
| }; |
There was a problem hiding this comment.
🐄, but I guess it's unavoidable here.
There was a problem hiding this comment.
yes unfortunately: https://github.com/gl-vis/gl-scatter3d#example
|
💃 |
- update src/index.js and src/assets/geo_assets.js 'version' export
using a falafel update
- done replacement of require('../package.json') so that webpack
is supported w/o a json loader
etpinard
added a commit
that referenced
this pull request
Jan 20, 2016
Replace json assets by js files
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mdtusz @bpostlethwaite
Webpack does not bundle up json files by default. It is possible using user-defined loaders e.g. this one for json files. But this is an extra hurdle for webpack users that we can fix on our end.
This PR takes one step towards supporting Webpack bundling without any special configs.
Note that I used this script to check for non-js files that are bundled into plotly.js.