Skip to content

Fixup html entity number #1820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 26, 2017
Merged

Fixup html entity number #1820

merged 2 commits into from
Jun 26, 2017

Conversation

etpinard
Copy link
Contributor

fixes #1814

Previously HTML entities entered as numbers were decoded to unicode for free via now-removed appendSVG method. When PR #1792 🔪 appendSVG, support for HTML entity numbers was dropped. This PR brings it back.

cc @cpsievert

@etpinard etpinard added status: reviewable bug something broken labels Jun 26, 2017
@alexcjohnson
Copy link
Collaborator

Looks good. Referencing #804 and #835 for why we're only concerned with these few entities. I may hunt around for a performant way to support all entities, but in the meantime this gets a 💃 !

@etpinard etpinard merged commit cace50d into master Jun 26, 2017
@etpinard etpinard deleted the fixup-html-entity-number branch June 26, 2017 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HTML entities no longer render in ticktext
2 participants