[WIP] some more performance optimizations #1776
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
just use node.innerHTML. It's fine, really!
etpinard
reviewed
Jun 12, 2017
| result = _context.appendSVG(converted); | ||
|
|
||
| if(!result) _context.text(str); | ||
| _context.node().innerHTML = convertToSVG(str); |
There was a problem hiding this comment.
Hmm. Does this work in IE?
There was a problem hiding this comment.
There was a problem hiding this comment.
oh crap you're right... fails even in IE11
|
If this works out, this PR is 🏆 This should get us pretty close to plotly.js working in jsdom out of the box, referencing: |
|
Alright, I suppose I could write some sort of feature detection to enable or disable this behavior... but I think the better solution (which with any luck will be even faster as well as cross-browser!) will be to just build elements like we do for everything else, rather than building a text string and turning that into elements. Going to give that a shot. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following on #1772 - some more poking around for performance bottlenecks.