Link style #1681
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -6,7 +6,7 @@ var util = require('@src/lib/svg_text_utils'); | |
| describe('svg+text utils', function() { | ||
| 'use strict'; | ||
|
|
||
| describe('convertToTspans', function() { | ||
|
|
||
| function mockTextSVGElement(txt) { | ||
| return d3.select('body') | ||
|
|
@@ -30,7 +30,7 @@ describe('svg+text utils', function() { | |
| expect(tspan.attr('style')).toBe(style); | ||
| } | ||
|
|
||
| function assertAnchorAttrs(node, style) { | ||
| var a = node.select('a'); | ||
|
|
||
| var WHITE_LIST = ['xlink:href', 'xlink:show', 'style'], | ||
|
|
@@ -44,6 +44,8 @@ describe('svg+text utils', function() { | |
| }); | ||
|
|
||
| expect(hasWrongAttr).toBe(false); | ||
|
|
||
| expect(a.attr('style')).toBe('cursor:pointer;' + (style || '')); | ||
| } | ||
|
|
||
| function listAttributes(node) { | ||
|
|
@@ -60,7 +62,7 @@ describe('svg+text utils', function() { | |
| d3.select('#text').remove(); | ||
| }); | ||
|
|
||
| it('checks for XSS attack in href', function() { | ||
| var node = mockTextSVGElement( | ||
| '<a href="javascript:alert(\'attack\')">XSS</a>' | ||
| ); | ||
|
|
@@ -70,7 +72,7 @@ describe('svg+text utils', function() { | |
| assertAnchorLink(node, null); | ||
| }); | ||
|
|
||
| it('checks for XSS attack in href (with plenty of white spaces)', function() { | ||
| var node = mockTextSVGElement( | ||
| '<a href = " javascript:alert(\'attack\')">XSS</a>' | ||
| ); | ||
|
|
@@ -80,7 +82,7 @@ describe('svg+text utils', function() { | |
| assertAnchorLink(node, null); | ||
| }); | ||
|
|
||
| it('whitelists relative hrefs (interpreted as http)', function() { | ||
| var node = mockTextSVGElement( | ||
| '<a href="/mylink">mylink</a>' | ||
| ); | ||
|
|
@@ -90,7 +92,7 @@ describe('svg+text utils', function() { | |
| assertAnchorLink(node, '/mylink'); | ||
| }); | ||
|
|
||
| it('whitelists http hrefs', function() { | ||
| var node = mockTextSVGElement( | ||
| '<a href="http://bl.ocks.org/">bl.ocks.org</a>' | ||
| ); | ||
|
|
@@ -100,7 +102,7 @@ describe('svg+text utils', function() { | |
| assertAnchorLink(node, 'http://bl.ocks.org/'); | ||
| }); | ||
|
|
||
| it('whitelists https hrefs', function() { | ||
| var node = mockTextSVGElement( | ||
| '<a href="https://plot.ly">plot.ly</a>' | ||
| ); | ||
|
|
@@ -110,7 +112,7 @@ describe('svg+text utils', function() { | |
| assertAnchorLink(node, 'https://plot.ly'); | ||
| }); | ||
|
|
||
| it('whitelists mailto hrefs', function() { | ||
| var node = mockTextSVGElement( | ||
| '<a href="mailto:[email protected]">support</a>' | ||
| ); | ||
|
|
@@ -120,7 +122,8 @@ describe('svg+text utils', function() { | |
| assertAnchorLink(node, 'mailto:[email protected]'); | ||
| }); | ||
|
|
||
| it('drops XSS attacks in href', function() { | ||
| // "XSS" gets interpreted as a relative link (http) | ||
|
|
||
| var textCases = [ | ||
| '<a href="XSS\" onmouseover="alert(1)\" style="font-size:300px">Subtitle</a>', | ||
| '<a href="XSS" onmouseover="alert(1)" style="font-size:300px">Subtitle</a>' | ||
|
|
@@ -130,12 +133,32 @@ describe('svg+text utils', function() { | |
| var node = mockTextSVGElement(textCase); | ||
|
|
||
| expect(node.text()).toEqual('Subtitle'); | ||
| assertAnchorAttrs(node, 'font-size:300px'); | ||
| assertAnchorLink(node, 'XSS'); | ||
| }); | ||
| }); | ||
|
|
||
| it('accepts href and style in <a> in any order and tosses other stuff', function() { | ||
| var textCases = [ | ||
| '<a href="x" style="y">z</a>', | ||
| '<a href=\'x\' style="y">z</a>', | ||
| '<A HREF="x"StYlE=\'y\'>z</a>', | ||
| '<a style=\'y\'href=\'x\'>z</A>', | ||
| '<a \t\r\n href="x" \n\r\t style="y" \n \t \r>z</a>', | ||
| '<a magic="true" href="x" weather="cloudy" style="y" speed="42">z</a>', | ||
| '<a href="x" style="y">z</a href="nope" style="for real?">', | ||
| ]; | ||
|
|
||
| textCases.forEach(function(textCase) { | ||
| var node = mockTextSVGElement(textCase); | ||
|
|
||
| expect(node.text()).toEqual('z'); | ||
| assertAnchorAttrs(node, 'y'); | ||
| assertAnchorLink(node, 'x'); | ||
| }); | ||
| }); | ||
|
|
||
| it('keeps query parameters in href', function() { | ||
| var textCases = [ | ||
| '<a href="https://abc.com/myFeature.jsp?name=abc&pwd=def">abc.com?shared-key</a>', | ||
| '<a href="https://abc.com/myFeature.jsp?name=abc&pwd=def">abc.com?shared-key</a>' | ||
|
|
@@ -150,7 +173,7 @@ describe('svg+text utils', function() { | |
| }); | ||
| }); | ||
|
|
||
| it('allows basic spans', function() { | ||
| var node = mockTextSVGElement( | ||
| '<span>text</span>' | ||
| ); | ||
|
|
@@ -159,7 +182,7 @@ describe('svg+text utils', function() { | |
| assertTspanStyle(node, null); | ||
| }); | ||
|
|
||
| it('ignores unquoted styles in spans', function() { | ||
| var node = mockTextSVGElement( | ||
| '<span style=unquoted>text</span>' | ||
| ); | ||
|
|
@@ -168,7 +191,7 @@ describe('svg+text utils', function() { | |
| assertTspanStyle(node, null); | ||
| }); | ||
|
|
||
| it('allows quoted styles in spans', function() { | ||
| var node = mockTextSVGElement( | ||
| '<span style="quoted: yeah;">text</span>' | ||
| ); | ||
|
|
@@ -177,7 +200,7 @@ describe('svg+text utils', function() { | |
| assertTspanStyle(node, 'quoted: yeah;'); | ||
| }); | ||
|
|
||
| it('ignores extra stuff after span styles', function() { | ||
| var node = mockTextSVGElement( | ||
| '<span style="quoted: yeah;"disallowed: indeed;">text</span>' | ||
| ); | ||
|
|
@@ -195,7 +218,7 @@ describe('svg+text utils', function() { | |
| assertTspanStyle(node, 'quoted: yeah&\';;'); | ||
| }); | ||
|
|
||
| it('decodes some HTML entities in text', function() { | ||
| var node = mockTextSVGElement( | ||
| '100μ & < 10 > 0 ' + | ||
| '100 × 20 ± 0.5 °' | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌