Remove dependencies on Plotly for Choropleth #165
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -9,9 +9,9 @@ | |||
|
|
|||
| 'use strict'; | |||
|
|
|||
| var Plotly = require('../../plotly'); | |||
| var Plots = require('../../plots/plots'); | |||
There was a problem hiding this comment.
Plots can stand on its own now so we should change things to directly require it whenever we come across Plotly.Plots.
|
@etpinard any ideas on those image test diffs? |
mdtusz
changed the title
|
Good to go now? |
|
💃 |
mdtusz
added a commit
that referenced
this pull request
Jan 7, 2016
Remove dependencies on Plotly for Choropleth
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just removed a few references to
Plotly.___where they cause circular dependency issues.