Recompute hover on click to increase click robustness #1646
Conversation
|
Hmm… has nothing to do with #1640, to the best of my knowledge. I was having a lot of trouble while working on this example in which, depending on how I move the mouse, maybe half of the clicks on the points go unregistered. The fundamental problem is that the point you're hovering over is only computed when the mouse moves or when the data changes, not when you click. That seems to be inadequate and result in a lot of dropped clicks. The solution here is to also just compute which point has been clicked when you actually click. |
|
Working on rebasing… |
|
#1582 is now in |
|
@rreusser I'm going to put this under the |
rreusser
force-pushed
the
recompute-hover-on-click
branch
from
6244f13 to
0acdea4
Compare
|
Sorry this one sat for a while. I really need that plugin that lets me flag github notifications I need to return to. I've rebased and am waiting for the test to confirm the fix is transferred over. |
|
@rreusser tests are ✅ Did you want to add anything else to this PR? Sounds like a solid improvement. |
|
@rreusser ping. |
|
I'm content with this. It's rebased and tested. 👍 |
|
Amazing! Thanks @rreusser 💃 |
Rehover caused a lot of problems with dropped clicks. This PR recomputes the hover data on click so that when it's used in the click, it's up to date. It's perhaps a bit of wasted effort, but it should solve the problems with dropped clicks.