Skip to content

Fix scattercarpet calc #1641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 1, 2017
Merged

Fix scattercarpet calc #1641

merged 2 commits into from
May 1, 2017

Conversation

rreusser
Copy link
Contributor

@rreusser rreusser commented May 1, 2017

This addresses @alexcjohnson's comment that scattercarpet was doing something weird and not handling array properties correctly. I mostly copied scattercarpet from scatterternary, but I wasn't quite able to reconstruct the removed line in this PR. I replaced it with arraysToCalcdata and it seems like things work fine though.

@rreusser rreusser added status: reviewable bug something broken labels May 1, 2017
@etpinard
Copy link
Contributor

etpinard commented May 1, 2017

That looks right. I should've caught that while reviewing that carpet PR. My mistake.

@rreusser would you mind a test case to 🔒 this down? Something similar to this suite and more precisely this case would more than suffice.

@rreusser
Copy link
Contributor Author

rreusser commented May 1, 2017

I'm currently on my way to plotcon and accidentally checked my iPhone cable so I have no wifi today. Anyone is free to seize control of this PR if the fix is needed urgently, otherwise I'll lock this down asap.

@alexcjohnson
Copy link
Collaborator

Added a test (I want this for my gradient test cases). I did it through a full plot since I wanted to test restyle too. I actually thought it might not work on restyle, due to this line and the fact we didn't make module.arraysToCalcdata like we did in some modules... but, test passes (as does a sanity check in the dashboard) so I think we're OK, just may point to an optimization we can do later for style changes like this, perhaps whenever we get around to overhauling restyle/relayout.

@etpinard
Copy link
Contributor

etpinard commented May 1, 2017

Oh that arraysToCalcdata check is a thing of the past 🔪

Restyle now does a recalc whenever an arrayOk attribute is or is set to an array.

@etpinard
Copy link
Contributor

etpinard commented May 1, 2017

But yeah, it might be better to 🔪 that in a different PR.

💃

@alexcjohnson alexcjohnson merged commit e54d009 into master May 1, 2017
@alexcjohnson alexcjohnson deleted the fix-scattercarpet branch May 1, 2017 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants