Move node-sass to devdeps and remove postinstall npm command #164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-daniel
changed the title
| @@ -94,6 +92,7 @@ | |||
| "karma-coverage": "^0.5.3", | |||
| "karma-firefox-launcher": "^0.1.6", | |||
| "karma-jasmine": "^0.3.6", | |||
| "node-sass": "^3.4.1", | |||
There was a problem hiding this comment.
@alexander-daniel can you bring xml2js down in the devDep too.
It is only used in the proprecess step:
There was a problem hiding this comment.
Ah yes sorry I forgot that one! Thanks!
|
💃 thanks so much! |
alexander-daniel
added a commit
that referenced
this pull request
Jan 6, 2016
Move node-sass to devdeps and remove postinstall npm command
This was referenced Jan 7, 2016
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@etpinard
Alrighty! So it looks like
node-sassis a pretty hefty friend. It's not really needed for production use, but if we remove thenpm run postinstallcommand, we have to check in thebuild/plotcss.jsandbuild/ploticon.jsfiles.One thing to note, if you make changes you'll have to run
npm run preprocessmanually, and that will update both of those assets, and you can then commit the changes.Removed those from the ignore files as well.
(not a bug, my finger slipped)