Better image test logs #1569
Merged
Better image test logs #1569
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add handle for request errors, to catch connections errors that can happen when the image server blows up - log error messages directly to stdout, so that they are written to the stdout as they happen in a child process exec block.
etpinard
commented
Apr 7, 2017
| - `git rebase` their local branch off the latest `master`, | ||
| - make sure to **not** `git add` the `dist/` folder (the `dist/` is updated only on verion bumps), | ||
| - write an overview of what the PR attempts to do, | ||
| - select the _Allow edits from maintainers_ option (see this [article](https://help.github.com/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork/) for more details). |
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One silver lining to this week's
nw.jsupgrade fiasco 🥈, I spent a lot of time staring at image request logs and found a few ways to make them easier to read.I hope this will benefit others when trying to make sense of image tests failures. 🍻