Skip to content

Scattermapbox BADNUM (w/o upgrading mapbox-gl) #1564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 7, 2017
Merged

Scattermapbox BADNUM (w/o upgrading mapbox-gl) #1564

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
aec6248
make sure mapbox-gl canvas does not inherit left and top css
etpinard Apr 7, 2017
1abbd90
:hocho: scattermapbox/calc.js | :recycle: scattergeo/calc.js
etpinard Apr 7, 2017
3e64aa0
update scattermapbox convert & hover
etpinard Apr 7, 2017
785bade
update mapbox baselines
etpinard Apr 7, 2017
5c2393a
:hocho: last remaining signs of `placeholder` key in calcdata
etpinard Mar 31, 2017
b5cd573
replace false values with BADNUM in empty calcdata traces
etpinard Apr 7, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions src/plots/mapbox/mapbox.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,10 +111,14 @@ proto.createMap = function(calcData, fullLayout, resolve, reject) {
});

// clear navigation container
var className = constants.controlContainerClassName,
controlContainer = self.div.getElementsByClassName(className)[0];
var className = constants.controlContainerClassName;
var controlContainer = self.div.getElementsByClassName(className)[0];
self.div.removeChild(controlContainer);

// make sure canvas does not inherit left and top css
map._canvas.canvas.style.left = '0px';
map._canvas.canvas.style.top = '0px';
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rreusser looking good:

image


self.rejectOnError(reject);

map.once('load', function() {
Expand Down Expand Up @@ -176,7 +180,6 @@ proto.createMap = function(calcData, fullLayout, resolve, reject) {

map.on('dragstart', unhover);
map.on('zoomstart', unhover);

};

proto.updateMap = function(calcData, fullLayout, resolve, reject) {
Expand Down