Histogram2dcontour relayout fix #1520
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- which fixes the references issues on relayout when `autocontour: true`
rreusser
reviewed
Mar 27, 2017
| var Lib = require('../../lib'); | ||
| var attributes = require('./attributes'); | ||
|
|
||
| module.exports = function handleContourDefaults(traceIn, traceOut, coerce) { |
There was a problem hiding this comment.
Interesting. Perhaps I'll need to merge/use this in carpet.
| @@ -30,5 +31,6 @@ module.exports = function supplyDefaults(traceIn, traceOut, defaultColor, layout | |||
| if(autocontour) coerce('ncontours'); | |||
| else coerce('contours.size'); | |||
There was a problem hiding this comment.
Can this line get the 🔪 ? It looks like handleContoursDefaults re-coerces this on the next line, but I could be mistaken.
There was a problem hiding this comment.
Oh oops. Good call!
There was a problem hiding this comment.
It's subtle though. Sometimes these things do need re-coercing depending on the coupling between parameter defaults. But this one look like it's maybe redundant.
|
Looks great 💃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1517 and DRYs up the
contoursdefaults logic forcontourandhistogram2dcontourtraces 🌴Thanks @rreusser for finding this bug 🔬 🪲