Update README.md #1496
Merged
Update README.md #1496
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add chart images to readme
|
Looks good! @cldougl can you wrap the image in an anchor so that click on it leads to https://plot.ly/javascript/ ? |
|
... or to some other page that might be better. |
|
yep - I think https://plot.ly/javascript/ will be best for now |
|
Also, I think it's pretty safe to swap the markdown image for p tag optional for vertical padding… I think… |
ok that's centered (I think that looks better @rreusser ) and linked to plot.ly/javascript
etpinard
reviewed
Mar 17, 2017
README.md
Outdated
| @@ -8,7 +8,10 @@ plotly.js is a high-level, declarative charting library. plotly.js ships with ov | |||
| chart types, including scientific charts, 3D graphs, statistical charts, SVG maps, financial charts, | |||
| and more. | |||
|
|
|||
|  | |||
| <p align="center"> | |||
| <a href="https://www.plot.ly/javascript"> | |||
There was a problem hiding this comment.
maybe a target="_blank" here?
+target _blank
|
(FWIW: I use vmd all the time for working on + previewing github markdown files locally. Auto-updates on save.) |
|
💃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add chart images to readme
@etpinard is that ok there or would you prefer to add the image to the doc section?