Fix xyz column convert routine for columns containing nulls #1491

etpinard · 2017-03-16T23:58:06Z

So that

var x = [  0,  0,   0,  5,  null,   5,  10,  10,   10 ];
var y = [  0,  5,  10,  0,  null,  10,   0,   5,   10 ];
var z = [  0, 50, 100, 50,  null, 255, 100, 510, 1010 ];

Plotly.newPlot('graph', [{
  type: 'heatmap',
  x: x,
  y: y,
  z: z
}])

doesn't lead to index errors.

@rreusser unfortunately, commit 93a70be wiil conflict with your carpet PR #1239. I can help merge master into #1239 once this PR is in.

- as Lib.distinctVals + Lib.findBin don't work properly (and shouldn't) for non-numeric values

rreusser · 2017-03-17T00:43:23Z

All good. It shouldn't be too bad. I hardly did anything except generalize the column names a bit since carpet === x => a, y => b, z => [x, y], more or less.

alexcjohnson · 2017-03-17T02:55:15Z

src/traces/heatmap/convert_column_xyz.js


    if(hasColumnText) text = Lib.init2dArray(y.length, x.length);

    for(i = 0; i < colLen; i++) {
-        ix = Lib.findBin(xCol[i] + xColdv.minDiff / 2, x);
-        iy = Lib.findBin(yCol[i] + yColdv.minDiff / 2, y);
+        if(xCol[i] !== BADNUM && yCol[i] !== BADNUM) {


Ah right - because xCol and yCol have already gone through d2c so anything invalid (null, text, whatever) will have become BADNUM - nice.

alexcjohnson · 2017-03-17T02:56:22Z

💃

don't try to fill z 2D with nulls in convert xyz column

93a70be

- as Lib.distinctVals + Lib.findBin don't work properly (and shouldn't) for non-numeric values

etpinard added status: reviewable bug something broken labels Mar 16, 2017

etpinard changed the title ~~Fix convert xyz column convert routine for columns containing nulls~~ Fix xyz column convert routine for columns containing nulls Mar 16, 2017

etpinard added this to the v1.25.0 milestone Mar 16, 2017

alexcjohnson reviewed Mar 17, 2017

View reviewed changes

etpinard merged commit b23fc92 into master Mar 17, 2017

etpinard deleted the convert-column-fixes branch March 17, 2017 03:23

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix xyz column convert routine for columns containing nulls #1491

Fix xyz column convert routine for columns containing nulls #1491

etpinard commented Mar 16, 2017

rreusser commented Mar 17, 2017

alexcjohnson Mar 17, 2017

alexcjohnson commented Mar 17, 2017

Fix xyz column convert routine for columns containing nulls #1491

Fix xyz column convert routine for columns containing nulls #1491

Conversation

etpinard commented Mar 16, 2017

rreusser commented Mar 17, 2017

alexcjohnson Mar 17, 2017

Choose a reason for hiding this comment

alexcjohnson commented Mar 17, 2017