Batch image export tests #1490
Merged
Batch image export tests #1490
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- in an effort to make `npm run test-export` not fail intermittently on the (weaker-hardware) CI machines.
- in an effort to reduce image-server "stress" in container 0 - this should also reduce total test time as test-jasmine is by far the slowest test command.
|
@alexcjohnson @monfera this should help ease out the intermittent CI failures. |
|
Awesome, lets get this up! 💃 |
|
2 for 2 so far. Hopefully, this keeps up! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, image export tests were simply firing requests to our image server all at once.
We currently (only) generate 21 images in this export test, so most machines can handle that fairly easily. But looks like (from all the intermittent failures) CI has a harder time getting through those 21 requests. So the solution is easy, simply batch and throttle the image export requests as we do already in the image comparison tests.
As a bonus, I moved the export test to container 1 after the jasmine tests which should reduce the total test time.