Log bar autorange fix #1475
Merged
Log bar autorange fix #1475
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etpinard
reviewed
Mar 14, 2017
| } | ||
| } | ||
| maybeExpand(barTop); | ||
| maybeExpand(barBase); |
There was a problem hiding this comment.
very nice simplification.
etpinard
reviewed
Mar 14, 2017
| }); | ||
|
|
||
| var ya = gd._fullLayout.yaxis; | ||
| expect(Axes.getAutoRange(ya)).toBeCloseToArray([1.496, 2.027], undefined, '(ya.range)'); |
There was a problem hiding this comment.
Nice tests! I wouldn't be opposed to adding a bar log image test too if you're up for it.
There was a problem hiding this comment.
Could be nice, but for now I think I'd better move on.
|
💃 image test or not. Thanks a lot! That would have taken me at least a full day to go fix this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1352 - makes autorange work with bar traces on log axes
@etpinard please review