Skip to content

CircleCI with Ubuntu 14.04, 2x parallelism and WebGL jasmine tests #1455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Mar 9, 2017
Merged

CircleCI with Ubuntu 14.04, 2x parallelism and WebGL jasmine tests #1455

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
0e3c61f
merge karma ciconf with (regular) conf
etpinard Mar 9, 2017
aa1aaef
comment & lint in karma conf
etpinard Mar 9, 2017
62d33b9
rm hasWebGLSupport early return in jasmine specs
etpinard Mar 9, 2017
100b993
rm unnecessary quotes in yml
etpinard Mar 9, 2017
14621e1
revamp circle.yml for ubuntu 14.04 with 2x parallel containers !!!
etpinard Mar 9, 2017
b42f021
use `karma-jasmine-spec-tags` to skip a few test on CI
etpinard Mar 9, 2017
8d7171f
add karma-verbose-reporter in dev deps
etpinard Mar 9, 2017
b86bf06
add `karma-spec-reporter` to log info about skipped specs
etpinard Mar 9, 2017
631533d
tweak precision to make tests pass on CI w/ Chrome 54
etpinard Mar 9, 2017
dbc6ca1
lock uglify-js to 2.7.x
etpinard Mar 9, 2017
e52f020
add no_citest script
etpinard Mar 9, 2017
33ae963
use (plain) npm run test-jasmine on CI
etpinard Mar 9, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,7 @@
"karma-coverage": "^1.0.0",
"karma-firefox-launcher": "^1.0.0",
"karma-jasmine": "^1.1.0",
"karma-jasmine-spec-tags": "^1.0.1",
"madge": "^1.6.0",
"node-sass": "^4.5.0",
"npm-link-check": "^1.2.0",
Expand Down
11 changes: 10 additions & 1 deletion test/jasmine/karma.conf.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ func.defaultConfig = {

// frameworks to use
// available frameworks: https://npmjs.org/browse/keyword/karma-adapter
frameworks: ['jasmine', 'browserify'],
frameworks: ['jasmine', 'jasmine-spec-tags', 'browserify'],

// list of files / patterns to load in the browser
//
Expand Down Expand Up @@ -119,6 +119,15 @@ func.defaultConfig = {
extensions: ['.js'],
watch: !isCI,
debug: true

// unfortunately a few tests don't behave well on CI
// using `karma-jasmine-spec-tags`
// add @noCI to the spec description to skip a spec on CI
client: {
tagPrefix: '@',
skipTags: isCI ? 'noCI' : null
},

}
};

Expand Down
2 changes: 1 addition & 1 deletion test/jasmine/tests/gl2d_click_test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ Plotly.register([
require('@lib/contourgl')
]);

describe('Test hover and click interactions', function() {
describe('@noCI Test hover and click interactions', function() {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one here should work on CI. I'll investigate.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done in #1459


var mock = require('@mocks/gl2d_14.json');
var mock2 = require('@mocks/gl2d_pointcloud-basic.json');
Expand Down
2 changes: 1 addition & 1 deletion test/jasmine/tests/mapbox_test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,7 +276,7 @@ describe('mapbox credentials', function() {
}, LONG_TIMEOUT_INTERVAL);
});

describe('mapbox plots', function() {
describe('@noCI, mapbox plots', function() {
'use strict';

var mock = require('@mocks/mapbox_0.json'),
Expand Down
2 changes: 1 addition & 1 deletion test/jasmine/tests/parcoords_test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,7 @@ describe('parcoords initialization tests', function() {
});
});

describe('parcoords', function() {
describe('@noCI parcoords', function() {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@monfera this suite here blows the process on CI.

Maybe next time you play around with the parcoords code you could try to investigate which it(s) exactly blow(s) up the process. Or better yet, try to make the test less resource intensive. Thanks in advance!


beforeAll(function() {
mock.data[0].dimensions.forEach(function(d) {
Expand Down
2 changes: 1 addition & 1 deletion test/jasmine/tests/scattermapbox_test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -451,7 +451,7 @@ describe('scattermapbox convert', function() {
}
});

describe('scattermapbox hover', function() {
describe('@noCI scattermapbox hover', function() {
'use strict';

var hoverPoints = ScatterMapbox.hoverPoints;
Expand Down