Clear gd._hoverdata before emitting plotly_unhover
#1448
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- so that in the case where a plotly_unhover handler calls a Plotly method (restyle, relayout and update which in turn call Plots.rehover), an infinite isn't triggered! - add test case showing the current infinite loop code path
etpinard
commented
Mar 6, 2017
| expect(hoverCnt).toEqual(2); | ||
| expect(unHoverCnt).toEqual(2); | ||
| }) | ||
| .then(done); |
There was a problem hiding this comment.
This test case led to
before the above dragelement patch.
|
Crazy. I certainly would not have caught that, but it makes sense. 💃 Sometime it might be worth making test cases corresponding to some of our other event-driven examples, both to test the events themselves and to guard against other interactions like this. The Mandelbrot explorer I made is one that comes to mind - where a zoom (relayout) event triggers a restyle (with new heatmap data) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1446
plotly_unhoverhandler calls a Plotly method (restyle, relayout and update which in turn callPlots.rehoveradded in Cache the last mousemove event #1304) an infinite loop ➰ isn't triggered (see Latest release leads to infinite loops when callingrestyleonplotly_hover#1446 for example)cc @rreusser @alexcjohnson